Skip to content

Use documented username/password for docker/login-action - #4587

Closed
mwtoews wants to merge 4 commits into
OSGeo:masterfrom
mwtoews:fix-docker-login-action-ghcr
Closed

mwtoews wants to merge 4 commits into
OSGeo:masterfrom
mwtoews:fix-docker-login-action-ghcr

Conversation

@mwtoews

@mwtoews mwtoews commented Oct 6, 2025

Copy link
Copy Markdown
Member

Looking at #4584 there appears to be an unrelated issue with docker/login-action, showing the following:

Run docker/login-action@v3
  with:
    registry: ghcr.io
    username: OSGeo
    logout: true
  env:
    PUSH_PACKAGES: true
    CONTAINER: proj
Error: Password required

This PR updates the usage to follow the docs for the action for both ghcr.io and default Docker Hub registries.

@mwtoews
mwtoews requested a review from hobu October 6, 2025 02:45
@mwtoews

mwtoews commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

Note that this PR skips the two relevant checks:
image
these need to be triggered via ${{ env.PUSH_PACKAGES == 'true' }} set with logic:

PUSH_PACKAGES: ${{ github.repository_owner == 'OSGeo' && github.event_name != 'pull_request' && (matrix.container == 'proj' || (matrix.container == 'proj-docs' && github.ref_name == 'master')) }}

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

The PROJ project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last two months and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add terminal output examples if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions Bot added the stale label Dec 5, 2025
@github-actions

Copy link
Copy Markdown
Contributor

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 2 months. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the PROJ project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions Bot closed this Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant